no-jira: bump k8s packages to v0.36#10713
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@patrickdillon: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (20)
💤 Files with no reviewable changes (1)
🚧 Files skipped from review as they are similar to previous changes (15)
📝 WalkthroughWalkthroughThe change upgrades the Go toolchain and dependencies, migrates Azure webhooks to controller-runtime custom APIs, adjusts Nutanix, Power VS, and Azure provider handling, and updates CI builder images. ChangesInstaller updates
Estimated code review effort: 4 (Complex) | ~45 minutes Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 golangci-lint (2.12.2)Error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@pkg/asset/installconfig/nutanix/nutanix.go`:
- Around line 203-211: The Prism cluster handling must validate response
structure before dereferencing fields. In
pkg/asset/installconfig/nutanix/nutanix.go at lines 203-211, guard the
single-cluster path and the choice-building loop before accessing Metadata,
Spec, Resources, Network, UUID, Name, or ExternalIP, handling invalid responses
without panicking. In pkg/asset/manifests/nutanix/infrastructure.go at line 38,
add the corresponding nil guard for pe.Spec.Name after GetCluster.
In `@pkg/asset/manifests/azure/cluster.go`:
- Around line 609-611: Add unit tests for getLBIP covering the default
10.0.0.100 address when it falls within the control-plane subnet CIDR, and
covering the case where getIPWithinCIDR selects a different available address.
Assert both the returned IP and error behavior.
In `@pkg/types/nutanix/helpers.go`:
- Around line 301-303: Update the filter construction in the image lookup around
ntnxclient.V3.ListImage to escape or safely encode imageName using the Nutanix
client’s supported filter API before interpolation; otherwise validate it
against an appropriate allow-list, while preserving exact-name matching for
valid image names.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
|
/test e2e-azurestack e2e-powervs-capi-ovn e2e-nutanix-ovn |
Bump k8s packages and necessary dependencies to v0.36.
go mod tidy && go mod vendor
111a1eb to
0cd28e3
Compare
|
Caution Failed to replace (edit) comment. This is likely due to insufficient permissions or the comment being deleted. Error details |
|
/test e2e-azurestack e2e-powervs-capi-ovn e2e-nutanix-ovn |
There was a problem hiding this comment.
🧹 Nitpick comments (3)
pkg/asset/manifests/azure/stack/v1beta1/azuremanagedmachinepooltemplate_webhook.go (1)
37-39: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚖️ Poor tradeoffSame deprecated
WithCustomDefaulter/WithCustomValidatorregistration pattern.Mirrors the concern raised in
azurecluster_webhook.go— these builder methods are deprecated in favor of the genericWithDefaulter[T]/WithValidator[T].🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@pkg/asset/manifests/azure/stack/v1beta1/azuremanagedmachinepooltemplate_webhook.go` around lines 37 - 39, Update the webhook builder in SetupWebhookWithManager to replace deprecated WithCustomDefaulter and WithCustomValidator registration with the generic WithDefaulter and WithValidator methods, using AzureManagedMachinePoolTemplate as the registered type while preserving the existing mpw handler and webhook setup.pkg/asset/manifests/azure/stack/v1beta1/azuremanagedmachinepool_webhook.go (1)
47-49: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚖️ Poor tradeoffSame deprecated
WithCustomDefaulter/WithCustomValidatorregistration pattern.Mirrors the concern raised in
azurecluster_webhook.go— these builder methods are deprecated in favor of the genericWithDefaulter[T]/WithValidator[T].🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@pkg/asset/manifests/azure/stack/v1beta1/azuremanagedmachinepool_webhook.go` around lines 47 - 49, Update the AzureManagedMachinePool webhook builder registration to replace deprecated WithCustomDefaulter and WithCustomValidator calls with the generic WithDefaulter and WithValidator methods, supplying AzureManagedMachinePool as the relevant type while preserving the existing manager and webhook setup.pkg/asset/manifests/azure/stack/v1beta1/azurecluster_webhook.go (1)
34-38: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winUse the typed webhook helpers here.
WithCustomDefaulterandWithCustomValidatorare deprecated incontroller-runtime; switching toWithDefaulter[AzureCluster]andWithValidator[AzureCluster]removes the repeatedruntime.Objecttype assertions inDefault,ValidateCreate, andValidateUpdate.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@pkg/asset/manifests/azure/stack/v1beta1/azurecluster_webhook.go` around lines 34 - 38, Update the webhook builder around Complete to replace deprecated WithCustomDefaulter and WithCustomValidator with the typed WithDefaulter[AzureCluster] and WithValidator[AzureCluster] helpers. Preserve the existing AzureCluster webhook behavior while allowing the typed callbacks to remove runtime.Object assertions from Default, ValidateCreate, and ValidateUpdate.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@pkg/asset/manifests/azure/stack/v1beta1/azurecluster_webhook.go`:
- Around line 34-38: Update the webhook builder around Complete to replace
deprecated WithCustomDefaulter and WithCustomValidator with the typed
WithDefaulter[AzureCluster] and WithValidator[AzureCluster] helpers. Preserve
the existing AzureCluster webhook behavior while allowing the typed callbacks to
remove runtime.Object assertions from Default, ValidateCreate, and
ValidateUpdate.
In `@pkg/asset/manifests/azure/stack/v1beta1/azuremanagedmachinepool_webhook.go`:
- Around line 47-49: Update the AzureManagedMachinePool webhook builder
registration to replace deprecated WithCustomDefaulter and WithCustomValidator
calls with the generic WithDefaulter and WithValidator methods, supplying
AzureManagedMachinePool as the relevant type while preserving the existing
manager and webhook setup.
In
`@pkg/asset/manifests/azure/stack/v1beta1/azuremanagedmachinepooltemplate_webhook.go`:
- Around line 37-39: Update the webhook builder in SetupWebhookWithManager to
replace deprecated WithCustomDefaulter and WithCustomValidator registration with
the generic WithDefaulter and WithValidator methods, using
AzureManagedMachinePoolTemplate as the registered type while preserving the
existing mpw handler and webhook setup.
Fix up types after CAPI and CAPX bump.
LoadBalancerPoolMemberTargetIP was removed in the CAPI provider version bump. The preceding case covers the logic that was removed.
CAPZ removed the constant for internal load balancer IP address. We can just hardcode it.
Fixup the forked azure stack CRDs after CAPI bump.
Update the rest of the images to go 1.26.
Nolint is causing automated tests to fail. Upgrading the function is in progress.
0cd28e3 to
f405c20
Compare
|
/lgtm |
openshift-ci
Bot
added
the
approved
|
Scheduling required tests: Scheduling tests matching the |
|
/verified by CI |
openshift-ci-robot
added
the
verified
|
@mkowalski: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@patrickdillon: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
3 participants
Bump k8s packages to v0.36. In order to do that, we drop some old cruft and make some minor API tweaks.
Summary by CodeRabbit